Skip to content

Add support to set PickerPage navigation button in Android #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2019

Conversation

bundyo
Copy link
Contributor

@bundyo bundyo commented Apr 4, 2019

PR Checklist

What is the current behavior?

Close button in Android can't be set on the left

What is the new behavior?

androidCloseButtonPosition="navigationButton" creates a NavigationButton on the left.

Fixes/Implements/Closes #14.

@ghost ghost assigned bundyo Apr 4, 2019
@ghost ghost added the new PR label Apr 4, 2019
@cla-bot cla-bot bot added the cla: yes label Apr 4, 2019
@bundyo bundyo requested a review from VladimirAmiorkov April 4, 2019 15:17
@bundyo bundyo requested a review from VladimirAmiorkov April 17, 2019 15:55
@VladimirAmiorkov VladimirAmiorkov merged commit 79662ca into master Apr 18, 2019
@ghost ghost removed the new PR label Apr 18, 2019
@VladimirAmiorkov VladimirAmiorkov deleted the bundev/add-modal-navigation-button-support branch April 18, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PickerPage close button can't be set as NavigationButton in Android (left to title)
2 participants